dep: update com_github_google_perfetto: v22.1 (current: v21.0)#19259
dep: update com_github_google_perfetto: v22.1 (current: v21.0)#19259rojkov merged 1 commit intoenvoyproxy:mainfrom
Conversation
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Faseela K <faseela.k@est.tech>
kfaseela
force-pushed
the
upgrade-com_github_google_perfetto
branch
from
8d5dbfa to
e6fbf24
Compare
|
/retest |
|
Retrying Azure Pipelines: |
|
@htuch @rojkov we should add an owner for Perfetto to https://github.com/envoyproxy/envoy/blob/main/CODEOWNERS This change look OK? If so I'll approve the deps |
rojkov
left a comment
rojkov
left a comment
There was a problem hiding this comment.
Thank you!
Yes, the change looks good to me.
|
Heh, I accidentally enabled auto-merge in my github mobile app and the PR got happily merged despite the deps label. |
i thought we had fixed it to not do that |
|
I think it's not the machinery's fault: the check is not marked as required. I should have been more cautious with the app: it didn't even give me a chance to edit the commit message. |
|
in this case i thought/hoped i had fixed this specific issue see here #18814 (comment) |
…proxy#19259) Signed-off-by: Josh Perry <josh.perry@mx.com>
4 participants
Signed-off-by: Faseela K faseela.k@est.tech
Fixes #19216