access logger: don't always create retry config.#19500
Merged
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
htuch
approved these changes
Jan 12, 2022
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM. I think better integration tests here would make sense, but given the time schedule and manual validation, we can push them to after the release if you want to add a TODO or file an issue.
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Previously we always created the proto and so always created the retry config Risk Level: low (bugfix) Testing: new unit test Docs Changes: n/a Release Notes: n/a h/t Raven who caught and root caused this. Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we always created the proto and so always created the retry config
Risk Level: low (bugfix)
Testing: new unit test
Docs Changes: n/a
Release Notes: n/a
Fixes commit #17469
h/t Raven who caught and root caused this.