Skip to content

ssl: support certificates without CommonName.#1970

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
PiotrSikora:no_commonname
Oct 31, 2017
Merged

ssl: support certificates without CommonName.#1970
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
PiotrSikora:no_commonname

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Broken in #1747.

Broken in envoyproxy#1747.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

@lizan @ggreenway

Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Piotr!

@mattklein123 mattklein123 merged commit 927b805 into envoyproxy:master Oct 31, 2017
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
* Remove delta update in Report batch

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* fix format

* reduce max_batch_number to 100
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants