route.proto: add is_optional field to ClusterSpecifierPlugin#20301
route.proto: add is_optional field to ClusterSpecifierPlugin#20301lizan merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Doug Fawley <dfawley@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
This looks great to me. @lizan, can you please provide a non-Google API review here? Thanks! |
|
/lgtm api |
|
@dfawley please fix CI. |
|
@ggreenway apologies; I had not noticed the CI failures. I fixed the formatting, so it should be good to go now. |
|
/lgtm api (based on Lizan's earlier approval, since it's just a formatting change since then) |
|
please specify a single label can be specified |
|
/lgtm api |
|
@dfawley do you plan to implement this in this PR? If not it should have not-implemented-hide tag. |
|
@lizan Any reason not to merge this? Thanks! |
…oxy#20301) When deploying a new cluster specifier plugin, it is often necessary to add it to the configuration before all clients can be updated to support it, with routing rules configured to prevent clients without support from selecting any routes referencing the plugin. This field will allow those clients to suppress the default behavior of NACKing any resource containing the unknown plugin. Risk Level: None Testing: None Docs Changes: None Release Notes: None Platform Specific Features: None Signed-off-by: Doug Fawley <dfawley@google.com>
4 participants
Signed-off-by: Doug Fawley dfawley@google.com
Commit Message: route.proto: add is_optional field to ClusterSpecifierPlugin
Additional Description:
When deploying a new cluster specifier plugin, it is often necessary to add it to the configuration before all clients can be updated to support it, with routing rules configured to prevent clients without support from selecting any routes referencing the plugin. This field will allow those clients to suppress the default behavior of NACKing any resource containing the unknown plugin.
Risk Level: None
Testing: None
Docs Changes: None
Release Notes: None
Platform Specific Features: None
@markdroth @ejona86