Skip to content

Fixed status check #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nmnellis wants to merge 2 commits into from
Closed

Fixed status check #2032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780ecf4
Fixed status check
Nov 9, 2017
442350c
fixed lower bound http status code as well
Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/common/http/filter/lua/lua_filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ int StreamHandleWrapper::luaRespond(lua_State* state) {

uint64_t status;
if (headers->Status() == nullptr ||
!StringUtil::atoul(headers->Status()->value().c_str(), status) || status < 200 ||
status >= 500) {
!StringUtil::atoul(headers->Status()->value().c_str(), status) || status < 100 ||
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational (1xx) status codes have special meaning and we should not allow a Lua script to send them, as they will confuse the connection manager, so that part was correct, but the error message below is wrong. But the other one was a bug. Thank you for fixing. We should have a test though. Do you mind changing one of the response tests to use a 5xx status code? If you don't want to bother I can fix this later today.

Copy link
Copy Markdown
Author

@nmnellis nmnellis Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaving town this afternoon and will be off for a few days. Otherwise i would be able to fix it after i get back.

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way. If you would like to contribute we can wait, otherwise I'm happy to fix it. If you want to go that route just close the PR and I will do another PR later today.

Copy link
Copy Markdown
Author

@nmnellis nmnellis Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the fix, i would rather come back to it merged than wait

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2034

status >= 600) {
luaL_error(state, ":status must be between 100-599");
}

Expand Down