thrift: configurable validate_clusters to override the default cluste…#20874
Conversation
…r validation Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
cc @rgs1 @tkovacs-2 |
| "unknown thrift cluster"); | ||
| } | ||
|
|
||
| TEST_F(ThriftConnectionManagerTest, UnknownClusterWithNegativeValidateClusters) { |
There was a problem hiding this comment.
nit: UnknownClusterWithValidateClustersDisabled
| "unknown thrift weighted cluster"); | ||
| } | ||
|
|
||
| TEST_F(ThriftConnectionManagerTest, UnknownWeightedClusterWithNegativeValidateClusters) { |
There was a problem hiding this comment.
nit: UnknownWeightedClusterWithValidateClustersDisabled
| "unknown thrift shadow cluster"); | ||
| } | ||
|
|
||
| TEST_F(ThriftConnectionManagerTest, UnknownMirrorPolicyClusterWithNegativeValidateClusters) { |
There was a problem hiding this comment.
nit: UnknownMirrorPolicyClusterWithValidateClustersDisabled
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
| // :ref:`trds | ||
| // <envoy_v3_api_field_extensions.filters.network.thrift_proxy.v3.ThriftProxy.trds>` | ||
| // option. Users may wish to override the default behavior in certain cases (for example when | ||
| // using TRDS with a static route table). |
There was a problem hiding this comment.
@htuch
What was wrong with the CDS in this comment?
In this form it is meaningless, TRDS means dynamic routing table.
There was a problem hiding this comment.
Sorry, you're right, let's revert.
There was a problem hiding this comment.
@htuch a gentle ping for another api modulo review
This reverts commit 6e04d54. Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
I went ahead and resolved the trivial merge conflict. I'd hoped that would revoke all the previous approvals, but it seems to have.
|
/retest |
|
Retrying Azure Pipelines: |
|
/lgtm api |
envoyproxy#20874) This is a continuation of envoyproxy#20577. Additional Description: Risk Level: low Testing: unit test Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
5 participants
…r validation
Signed-off-by: kuochunghsu kuochunghsu@pinterest.com
Commit Message:
This is a continuation of #20577.
Additional Description:
Risk Level: low
Testing: unit test
Docs Changes: proto
Release Notes: current.rst