Skip to content

dns_filter: simpilfy dns filter fuzz tests#21166

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
botengyao:simplifyDnsfuzzer
May 6, 2022
Merged

dns_filter: simpilfy dns filter fuzz tests#21166
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
botengyao:simplifyDnsfuzzer

Conversation

@botengyao
Copy link
Copy Markdown
Member

Signed-off-by: Boteng Yao boteng@google.com

  • In this PR, #20744 the answer message is disabled.
  • Remove separate fuzzing of the parseDnsQueryRecord as it is tested as part of the parseDnsObject method.
  • Remove fuzz_function randomization and only test the parseDnsObject method as it is used in the filter implementation.

Commit Message: simplify dns filter fuzz tests
Additional Description:
Risk Level: low
Testing: fuzz test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Boteng Yao <boteng@google.com>
@botengyao botengyao requested a review from mattklein123 as a code owner May 5, 2022 17:06
@botengyao
Copy link
Copy Markdown
Member Author

/assign @yanavlasov

@botengyao botengyao changed the title Simpilfy dns filter fuzz tests dns_filter: simpilfy dns filter fuzz tests May 5, 2022
@botengyao
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21166 (comment) was created by @botengyao.

see: more, trace.

@mattklein123 mattklein123 merged commit 581be68 into envoyproxy:main May 6, 2022
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Signed-off-by: Boteng Yao <boteng@google.com>
@botengyao botengyao deleted the simplifyDnsfuzzer branch September 1, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants