Fix compilation on 32 bit#2134
Closed
costinm wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
Conversation
mattklein123
previously approved these changes
Nov 30, 2017
Member
|
@costinm please fix DCO. Thank you! |
Signed-off-by: Costin Manolache <costin@gmail.com>
Member
|
Sorry I missed this the first time around (in #1795), but I think this is the same problem that we had on OS X. If uint64_t is typedef'd as I'm curious if that would solve your compilation error as well (because maybe some day there will be a command line flag that really needs to be 64 bit). |
Contributor
Author
|
Thanks a lot - the HAVE_LONG_LONG worked ! |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This PR allows platform implementations of a generic (and potentially persistent) key-value store to be registered with the Engine. Internal components can look up these implementations by name. The internal implementation and wiring in this PR is platform agnostic, but this PR adds a public API for Java/Kotlin only, initially. iOS and other public APIs to follow in upcoming PRs. Part of #2077. Risk Level: Low Testing: New Unit + Integration Coverage Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This PR allows platform implementations of a generic (and potentially persistent) key-value store to be registered with the Engine. Internal components can look up these implementations by name. The internal implementation and wiring in this PR is platform agnostic, but this PR adds a public API for Java/Kotlin only, initially. iOS and other public APIs to follow in upcoming PRs. Part of #2077. Risk Level: Low Testing: New Unit + Integration Coverage Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: fix compilation on arm (pi) and 32 bit machines
Description:
The cross compiler for arm doesn't like the 64bit options, previous PR updated the other
settings.
Risk Level: Low
Testing:
Manual build/run on pi.