Skip to content

wasm: use npm install instead of clean-install.#21481

Closed
PiotrSikora wants to merge 2 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-npm_install
Closed

wasm: use npm install instead of clean-install.#21481
PiotrSikora wants to merge 2 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-npm_install

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #21481 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label May 27, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #21481 was opened by PiotrSikora.

see: more, trace.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora marked this pull request as ready for review May 27, 2022 17:37
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21481 (comment) was created by @PiotrSikora.

see: more, trace.

@daixiang0
Copy link
Copy Markdown
Member

Is this a fix for a recent unstable wasm build?

@KBaichoo
Copy link
Copy Markdown
Contributor

KBaichoo commented Jun 2, 2022

@PiotrSikora you need to merge main

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

Superseded by #21487.

@PiotrSikora PiotrSikora closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants