dfp: consistent behavior on DNS resolution failure#21810
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Jun 22, 2022
Merged
dfp: consistent behavior on DNS resolution failure#21810alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ravenblackx
approved these changes
Jun 21, 2022
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
Risk Level: low Testing: fixed integration tests Docs Changes: n/a Release Notes: n/a Fixes envoyproxy#21410 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in #19588 (and previously) where after DNS resolutoin fail, subsequent requests weren't blackholed by the filter.
Risk Level: low
Testing: fixed integration tests
Docs Changes: n/a
Release Notes: n/a
Fixes #21410