Skip to content

oauth2: add "default_expires_in" config option#22029

Closed
riptl wants to merge 1 commit intoenvoyproxy:mainfrom
riptl:oauth-default-expire-in
Closed

oauth2: add "default_expires_in" config option#22029
riptl wants to merge 1 commit intoenvoyproxy:mainfrom
riptl:oauth-default-expire-in

Conversation

@riptl
Copy link
Copy Markdown
Contributor

@riptl riptl commented Jul 6, 2022

Signed-off-by: Richard Patel me@terorie.dev

Commit Message: oauth2: add "default_expires_in" config option
Additional Description: Fixes compatibility with OAuth 2.0 authorization servers that don't provide the "expires_in" property in the token response
Risk Level: Low
Testing: Added OAuth client tests for two new branches (default expires_in, missing default or explicit expires_in)
Docs Changes: Inline API proto
Release Notes: oauth2 filter: added "default_expires_in" property for authorization servers that don't provide the "expires_in" token response property
Fixes #14254
Continuation of #14625

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #22029 was opened by terorie.

see: more, trace.

Signed-off-by: Richard Patel <me@terorie.dev>
@riptl riptl force-pushed the oauth-default-expire-in branch from 76c87aa to 865e160 Compare July 6, 2022 05:40
@htuch htuch assigned lizan and unassigned htuch Jul 7, 2022
@htuch
Copy link
Copy Markdown
Member

htuch commented Jul 7, 2022

Re-assigning API review to @lizan as I'm out.

@lizan
Copy link
Copy Markdown
Member

lizan commented Jul 7, 2022

/lgtm api

can you check CI failures?

@repokitteh-read-only repokitteh-read-only Bot removed the api label Jul 7, 2022
@adisuissa
Copy link
Copy Markdown
Contributor

Still waiting on CI errors fix.
/wait

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 11, 2022
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants