Skip to content

Revert "build(deps): bump orjson from 3.6.7 to 3.7.7 in /tools/base (…#22116

Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom
phlax:revert-orjson-bump
Jul 12, 2022
Merged

Revert "build(deps): bump orjson from 3.6.7 to 3.7.7 in /tools/base (…#22116
wrowe merged 1 commit intoenvoyproxy:mainfrom
phlax:revert-orjson-bump

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jul 11, 2022

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…nvoyproxy#22112)"

This reverts commit 2f8b986.

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Jul 11, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #22116 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 11, 2022

pending outcome of https://dev.azure.com/cncf/envoy/_build/results?buildId=112577&view=logs&s=38ceb128-5055-565c-88b0-b52f284e9b30

...we probably want to land this quickly

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 11, 2022

yep, the dep is broken so we do want this for now - i can land a better fix tomorrow once ci is green again

cc @adisuissa

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 11, 2022
Copy link
Copy Markdown
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a stop gap until packaging on arm64 can be resolved

@wrowe wrowe merged commit cedb988 into envoyproxy:main Jul 12, 2022
tyxia pushed a commit to tyxia/envoy that referenced this pull request Jul 12, 2022
envoyproxy#22116)

Revert "build(deps): bump orjson from 3.6.7 to 3.7.7 in /tools/base (envoyproxy#22112)"

This reverts commit 2f8b986.

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Tianyu Xia <tyxia@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants