rate_limit_quota: [Doc] add the docs for rate limit quota feature by tyxia · Pull Request #22539 · envoyproxy/envoy

tyxia · 2022-08-03T14:21:33Z

Remove not_implemented_hide from the API proto
Fix the doc and format failures that were hidden under not_implemented_hide
Add the feature doc

Signed-off-by: Tianyu Xia tyxia@google.com

Signed-off-by: Tianyu Xia <tyxia@google.com>

repokitteh-read-only · 2022-08-03T14:21:38Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #22539 was opened by tyxia.

see: more, trace.

Signed-off-by: Tianyu Xia <tyxia@google.com>

repokitteh-read-only · 2022-08-03T17:16:03Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #22539 was synchronize by tyxia.

see: more, trace.

Signed-off-by: Tianyu Xia <tyxia@google.com>

github-actions · 2022-09-08T20:01:30Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

tyxia · 2022-09-15T22:08:22Z

/retest

repokitteh-read-only · 2022-09-15T22:08:26Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22539 (comment) was created by @tyxia.

see: more, trace.

Signed-off-by: Tianyu Xia <tyxia@google.com>

tyxia · 2022-09-29T17:40:07Z

/wait

Signed-off-by: tyxia <tyxia@google.com>

adisuissa

LGTM, thanks.
Deferring to @phlax for a final review and merge.

phlax · 2022-11-16T21:17:58Z

ill take a look tomorrow

tyxia · 2022-11-16T21:27:32Z

/docs

repokitteh-read-only · 2022-11-16T21:27:35Z

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22539/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22539 (comment) was created by @tyxia.

see: more, trace.

Signed-off-by: tyxia <tyxia@google.com>

tyxia · 2022-11-16T21:52:03Z

/docs

repokitteh-read-only · 2022-11-16T21:52:07Z

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22539/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22539 (comment) was created by @tyxia.

see: more, trace.

tyxia

Thanks for the review, Adi!

tyxia · 2022-11-17T15:05:32Z

/retest

repokitteh-read-only · 2022-11-17T15:05:41Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22539 (comment) was created by @tyxia.

see: more, trace.

phlax · 2022-11-18T16:17:44Z

apologies for delay - i will try and look over the w/end or first thing next week

Signed-off-by: tyxia <tyxia@google.com>

tyxia · 2022-11-21T21:02:10Z

/docs

repokitteh-read-only · 2022-11-21T21:02:15Z

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22539/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22539 (comment) was created by @tyxia.

see: more, trace.

phlax

overall looks great, clear and understandable

i was going to say - would be good to add a sandbox for this - but then read about no OSS implementation available atm

apologies again for the terrible delay in reviewing

a few grammar/format nits inline ...

Signed-off-by: tyxia <tyxia@google.com>

tyxia · 2022-11-22T14:42:33Z

@phlax Thank you very much for the thorough review! PTAL.

phlax

lgtm, thanks @tyxia

[WIP] Add the docs for rate limit quota filter

3bdedfb

Signed-off-by: Tianyu Xia <tyxia@google.com>

tyxia added 2 commits August 3, 2022 15:18

add final new line

3b73010

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

4b45bc5

Signed-off-by: Tianyu Xia <tyxia@google.com>

repokitteh-read-only Bot added the api label Aug 3, 2022

repokitteh-read-only Bot assigned adisuissa Aug 3, 2022

tyxia added 15 commits August 3, 2022 17:41

fix docs

54a7f42

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

42bc642

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

eb37eec

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

88a3a94

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

6c144b9

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

17d0d52

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

e7f9dcb

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

8117c76

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix docs

4f94352

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix the docs

ab87c06

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix doc

b5beb80

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix doc

8b5cc01

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix doc

1af858c

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix doc

ff58f57

Signed-off-by: Tianyu Xia <tyxia@google.com>

fix doc

9dfd549

Signed-off-by: Tianyu Xia <tyxia@google.com>

github-actions Bot added stale stalebot believes this issue/PR has not been touched recently and removed stale stalebot believes this issue/PR has not been touched recently labels Sep 8, 2022

fix doc

220d7ff

Signed-off-by: Tianyu Xia <tyxia@google.com>

tyxia mentioned this pull request Sep 25, 2022

rate_limit_quota: Quota based rate limiting, part 1 #22135

Merged

repokitteh-read-only Bot added the waiting label Nov 14, 2022

update the formatting

dc5113f

Signed-off-by: tyxia <tyxia@google.com>

repokitteh-read-only Bot removed the waiting label Nov 16, 2022

tyxia changed the title ~~rate_limit_quota: [Doc change] add the docs for rate limit quota feature~~ rate_limit_quota: [Doc] add the docs for rate limit quota feature Nov 16, 2022

adisuissa previously approved these changes Nov 16, 2022

View reviewed changes

repokitteh-read-only Bot removed the api label Nov 16, 2022

formatting

3b5ad52

Signed-off-by: tyxia <tyxia@google.com>

tyxia dismissed adisuissa’s stale review via 3b5ad52 November 16, 2022 21:32

repokitteh-read-only Bot added the api label Nov 16, 2022

tyxia commented Nov 16, 2022

View reviewed changes

Comment thread docs/root/configuration/http/http_filters/rate_limit_quota_filter.rst

Comment thread docs/root/configuration/http/http_filters/rate_limit_quota_filter.rst

tyxia added 3 commits November 21, 2022 19:00

move configuration to the file that can be downloaded

1a5073c

Signed-off-by: tyxia <tyxia@google.com>

fix format

2968b34

Signed-off-by: tyxia <tyxia@google.com>

fix format

866a621

Signed-off-by: tyxia <tyxia@google.com>

phlax reviewed Nov 22, 2022

View reviewed changes

update per review comments

b8854dd

Signed-off-by: tyxia <tyxia@google.com>

phlax approved these changes Nov 22, 2022

View reviewed changes

phlax enabled auto-merge (squash) November 22, 2022 14:45

phlax merged commit e51e81c into envoyproxy:main Nov 22, 2022

tyxia deleted the rls_doc branch November 22, 2022 16:28

Conversation

tyxia commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Aug 3, 2022

Uh oh!

repokitteh-read-only Bot commented Aug 3, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

tyxia commented Sep 15, 2022

Uh oh!

repokitteh-read-only Bot commented Sep 15, 2022

Uh oh!

tyxia commented Sep 29, 2022

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

phlax commented Nov 16, 2022

Uh oh!

tyxia commented Nov 16, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 16, 2022

Uh oh!

tyxia commented Nov 16, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 16, 2022

Uh oh!

tyxia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tyxia commented Nov 17, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 17, 2022

Uh oh!

phlax commented Nov 18, 2022

Uh oh!

tyxia commented Nov 21, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 21, 2022

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tyxia commented Nov 22, 2022

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tyxia commented Aug 3, 2022 •

edited

Loading