fix compatibility with data-plane-api commit fc64085#2329
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jan 9, 2018
brian-pane:datasource/2315
Merged
fix compatibility with data-plane-api commit fc64085#2329mattklein123 merged 1 commit intoenvoyproxy:masterfrom brian-pane:datasource/2315
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
brian-pane:datasource/2315
Conversation
That data-plane-api commit changed an existing field name, so this PR updates the Envoy code correspondingly in order to avoid surprising anybody who needs to pick up any subsequent changes to data-plane-api. Signed-off-by: Brian Pane <bpane@pinterest.com>
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
data-plane-api commit fc64085 changed an existing field name, so
this PR updates the Envoy code correspondingly in order to avoid
surprising anybody who needs to pick up any subsequent changes to
data-plane-api.
Related Issues: #2315
Risk Level: Low
Testing:
Ran the Envoy regression tests
API Changes:
envoyproxy/data-plane-api#393
Signed-off-by: Brian Pane bpane@pinterest.com