tls: support for api::v2::DataSource's new inline_string option#2341
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jan 10, 2018
brian-pane:datasource/2315
Merged
tls: support for api::v2::DataSource's new inline_string option#2341mattklein123 merged 1 commit intoenvoyproxy:masterfrom brian-pane:datasource/2315
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
brian-pane:datasource/2315
Conversation
Signed-off-by: Brian Pane <bpane@pinterest.com>
ggreenway
approved these changes
Jan 10, 2018
htuch
approved these changes
Jan 10, 2018
mattklein123
approved these changes
Jan 10, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Catching up with the extended
DataSourcedefinition in data-plane-apiRisk Level: Low
Testing: Updated unit tests included
API Changes: PR 393
Signed-off-by: Brian Pane bpane@pinterest.com