deprecating envoy.reloadable_features.deprecate_global_int#23613
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
jmarantz
reviewed
Oct 21, 2022
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
basically lgtm; makes sense to me to drop that settings as no one ever really changed it to my knowledge :)
Is there some general reason not to support int settings though? It seems this PR is part of a bigger mission I was not aware of.
|
|
||
| constexpr absl::string_view DelimiterForInlineHeaders{","}; | ||
| constexpr absl::string_view DelimiterForInlineCookies{"; "}; | ||
| const static int kMinHeadersForLazyMap = 3; // Arbitrary hard-coded value. |
Contributor
There was a problem hiding this comment.
I think it's better than arbitrary :) @adisuissa did ran microbenchmarks to at least sanity-check that choice.
Contributor
There was a problem hiding this comment.
3 was chosen after doing some benchmarks (#12656).
| * feature value (defaults to 3, if not set), all headers are added to a map, to allow | ||
| * fast access given a header key. Once the map is initialized, it will be used even if the number | ||
| * of headers decreases below the threshold. | ||
| * When the list size is greater or equal to the default min size (3), all headers are added to a |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes #23593