rate_limit_quota: [API] Support Envoy node info in `RateLimitQuotaUsageReports` by tyxia · Pull Request #24014 · envoyproxy/envoy

tyxia · 2022-11-15T21:43:36Z

Even though our (Google) RLQS server doesn't need this, there are needs/use cases from other RLQS customers that the RQLS server will receive reports from many envoy nodes across various regions, clusters and tenants. And the customers will use this Envoy node which contains all of this information to distinguish the tenant/region/cluster and to apply the appropriate rate limiting policies.

This PR addresses #23585.

Signed-off-by: tyxia tyxia@google.com

Risk Level: LOW
Testing: N/A

…geReports` Signed-off-by: tyxia <tyxia@google.com>

repokitteh-read-only · 2022-11-15T21:43:40Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24014 was opened by tyxia.

see: more, trace.

repokitteh-read-only · 2022-11-15T21:43:45Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #24014 was opened by tyxia.

see: more, trace.

Signed-off-by: tyxia <tyxia@google.com>

tyxia · 2022-11-16T14:08:56Z

/retest

deflake

repokitteh-read-only · 2022-11-16T14:09:04Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24014 (comment) was created by @tyxia.

see: more, trace.

tyxia · 2022-11-16T15:41:48Z

@htuch Thanks for the review! PTAL.

(The CI failure is caused by CI/CD infra that one agent is not responding... I will re-test it before submitting this PR).

tyxia · 2022-11-16T18:38:13Z

/retest

repokitteh-read-only · 2022-11-16T18:38:19Z

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24014 (comment) was created by @tyxia.

see: more, trace.

tyxia · 2022-11-17T04:48:30Z

/retest

repokitteh-read-only · 2022-11-17T04:48:37Z

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24014 (comment) was created by @tyxia.

see: more, trace.

htuch

/lgtm api

htuch · 2022-11-18T05:12:08Z

@tyxia do you want to fold in the implementation PR into this one? I'm pretty sure that combined this is a small PR.

tyxia · 2022-11-18T13:59:02Z

@tyxia do you want to fold in the implementation PR into this one? I'm pretty sure that combined this is a small PR.

Yea, the implementation should be pretty straightforward. We just need to set this info by the Node from localInfo.
The only issue is that the baseline impl PR (#22135 ) has not been merged yet, so there is really no implementation code to add at this point :)
We can either 1) check in this API proto change first 2) Or hold it off until baseline impl is merged. Either works for me

tyxia · 2022-11-19T14:40:15Z

/retest

repokitteh-read-only · 2022-11-19T14:40:23Z

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24014 (comment) was created by @tyxia.

see: more, trace.

htuch · 2022-11-21T03:48:33Z

Yep, I suggest merging in the implementation with this PR and let's review together.

jmarantz · 2022-11-24T15:34:41Z

/wait

github-actions · 2022-12-24T16:01:17Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

tyxia · 2022-12-28T14:08:25Z

/wait

I will update this PR once other parts of RLQS are ready.

github-actions · 2023-01-27T20:01:20Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

tyxia · 2023-01-27T20:27:30Z

I will work on this once other parts of impl are merged. Then I will merge corresponding impl into this proto change, as Harvey suggested.

github-actions · 2023-02-27T00:03:05Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

zuercher · 2023-02-27T19:53:31Z

Is this PR still in progress?

tyxia · 2023-02-27T19:56:24Z

Is this PR still in progress?

Yes, this PR is currently on-hold to wait for other pieces of project to be merged first. But I will revisit this PR soon.

github-actions · 2023-03-29T20:01:22Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions · 2023-04-06T00:02:40Z

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

rate_limit_quota: [API] Support Envoy node info in `RateLimitQuotaUsa…

879ff9c

…geReports` Signed-off-by: tyxia <tyxia@google.com>

repokitteh-read-only Bot added the api label Nov 15, 2022

repokitteh-read-only Bot assigned htuch Nov 15, 2022

htuch reviewed Nov 16, 2022

View reviewed changes

Comment thread api/envoy/service/rate_limit_quota/v3/rlqs.proto Outdated

tyxia added 4 commits November 16, 2022 04:27

update per review

d27211d

Signed-off-by: tyxia <tyxia@google.com>

update per review

79c1089

Signed-off-by: tyxia <tyxia@google.com>

update per review

bf6da8d

Signed-off-by: tyxia <tyxia@google.com>

fix proto format

c35bc3b

Signed-off-by: tyxia <tyxia@google.com>

tyxia marked this pull request as ready for review November 16, 2022 15:41

htuch reviewed Nov 18, 2022

View reviewed changes

repokitteh-read-only Bot added the waiting label Nov 24, 2022

github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 24, 2022

github-actions Bot removed the stale stalebot believes this issue/PR has not been touched recently label Dec 28, 2022

github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 27, 2023

github-actions Bot removed the stale stalebot believes this issue/PR has not been touched recently label Jan 28, 2023

github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 27, 2023

github-actions Bot removed the stale stalebot believes this issue/PR has not been touched recently label Feb 27, 2023

github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 29, 2023

github-actions Bot closed this Apr 6, 2023

tyxia deleted the rlqs_envoy_node branch December 26, 2024 04:27

Conversation

tyxia commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Nov 15, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 15, 2022

Uh oh!

Uh oh!

tyxia commented Nov 16, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 16, 2022

Uh oh!

tyxia commented Nov 16, 2022

Uh oh!

tyxia commented Nov 16, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 16, 2022

Uh oh!

tyxia commented Nov 17, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 17, 2022

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

htuch commented Nov 18, 2022

Uh oh!

tyxia commented Nov 18, 2022

Uh oh!

tyxia commented Nov 19, 2022

Uh oh!

repokitteh-read-only Bot commented Nov 19, 2022

Uh oh!

htuch commented Nov 21, 2022

Uh oh!

jmarantz commented Nov 24, 2022

Uh oh!

github-actions Bot commented Dec 24, 2022

Uh oh!

tyxia commented Dec 28, 2022

Uh oh!

github-actions Bot commented Jan 27, 2023

Uh oh!

tyxia commented Jan 27, 2023

Uh oh!

github-actions Bot commented Feb 27, 2023

Uh oh!

zuercher commented Feb 27, 2023

Uh oh!

tyxia commented Feb 27, 2023

Uh oh!

github-actions Bot commented Mar 29, 2023

Uh oh!

github-actions Bot commented Apr 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tyxia commented Nov 15, 2022 •

edited

Loading