rate_limit: Add time unit month and year#24070
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Nov 21, 2022
Merged
Conversation
Signed-off-by: tyxia <tyxia@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
reviewed
Nov 18, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Please add release notes as this is a user-facing change.
Signed-off-by: tyxia <tyxia@google.com>
tyxia
commented
Nov 18, 2022
Member
Author
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
Thanks for the review! Release Note has been added.
PTAL
Signed-off-by: tyxia <tyxia@google.com>
adisuissa
approved these changes
Nov 18, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
Code changes LGTM!
/lgtm api
Contributor
|
cc'ing @esmet @mattklein123 as filter codeowners |
mattklein123
approved these changes
Nov 21, 2022
ggreenway
pushed a commit
that referenced
this pull request
Dec 9, 2024
Following on from #24070 and adding support for week as a unit of time for ratelimits as this is something my team currently needs and WEEK felt sad as it was missing the protobuf party. Ideally we would have something like #33277 but in the interim it makes sense to add WEEK here since we have every other period already except week. Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com>
update-envoy Bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Dec 9, 2024
Following on from envoyproxy/envoy#24070 and adding support for week as a unit of time for ratelimits as this is something my team currently needs and WEEK felt sad as it was missing the protobuf party. Ideally we would have something like envoyproxy/envoy#33277 but in the interim it makes sense to add WEEK here since we have every other period already except week. Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com> Mirrored from https://github.com/envoyproxy/envoy @ 33fb49977a10657a84a4aff1ea8c7988c54e3c42
phlax
pushed a commit
to phlax/envoy-openssl
that referenced
this pull request
Mar 7, 2025
Following on from envoyproxy/envoy#24070 and adding support for week as a unit of time for ratelimits as this is something my team currently needs and WEEK felt sad as it was missing the protobuf party. Ideally we would have something like envoyproxy/envoy#33277 but in the interim it makes sense to add WEEK here since we have every other period already except week. Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #23844 and #24031, @renuka-fernando wants to have time unit
monthandyearfor his business needRelease note added.
Signed-off-by: Tianyu Xia tyxia@google.com