Skip to content

mobile: force registering request uuid extension#24304

Merged
alyssawilk merged 7 commits intoenvoyproxy:mainfrom
alyssawilk:uuid
Dec 2, 2022
Merged

mobile: force registering request uuid extension#24304
alyssawilk merged 7 commits intoenvoyproxy:mainfrom
alyssawilk:uuid

Conversation

@alyssawilk
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk commented Dec 1, 2022

This is required for HTTP data plane requests

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/mobile-maintainers: FYI only for changes made to (mobile/).
envoyproxy/mobile-maintainers assignee is @jpsim

🐱

Caused by: #24304 was opened by alyssawilk.

see: more, trace.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Augustyniak
Augustyniak previously approved these changes Dec 1, 2022
}
};

DECLARE_FACTORY(UUIDRequestIDExtensionFactory);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing declaration striking again 🙃

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but now we can fix it in one PR :-D

jpsim
jpsim previously approved these changes Dec 1, 2022
@alyssawilk alyssawilk enabled auto-merge (squash) December 1, 2022 21:51
@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Dec 2, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24304 (comment) was created by @jpsim.

see: more, trace.

Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim dismissed stale reviews from Augustyniak and themself via e1b3826 December 2, 2022 15:55
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added 2 commits December 2, 2022 11:19
* origin/main:
  Start slow start window on first successful HC, make slow start re-enterable (envoyproxy#23946)
  contrib-sipproxy: rework sipproxy stats (envoyproxy#24165)
  build(deps): bump github/codeql-action from 2.1.32 to 2.1.35 (envoyproxy#24292)
  build(deps): bump node from `c59fb39` to `80844b6` in /examples/ext_authz/auth/http-service (envoyproxy#24274)
  build(deps): bump actions/upload-artifact from 2 to 3 (envoyproxy#24121)
  build(deps): bump mysql from `96439dd` to `66efaaa` in /examples/mysql (envoyproxy#24273)
  build(deps): bump grpcio from 1.50.0 to 1.51.1 in /examples/grpc-bridge/client (envoyproxy#24272)
  Allow mobile/library/common/jni/ to be built on non-Android platforms. (envoyproxy#24299)
  generic proxy: added drain support to generic proxy to doing graceful closes on connections when possible (envoyproxy#24220)
  Reduce Route/VirtualHost memory utilization by avoiding RateLimitPolicy instances when not needed (envoyproxy#24243)
  Reduce VirtualHost memory utilization by avoiding CatchAllVirtualCluster when not needed (envoyproxy#24182)
  Fix mobile/tools/check_format.sh to re-apply envoyproxy#2698 (envoyproxy#24300)
  upstream: don't require `source_address` in `upstream_bind_config` (envoyproxy#24250)
  Quiche roll 20221201150327 (envoyproxy#24290)

Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Comment thread test/run_envoy_bazel_coverage.sh
jpsim added 2 commits December 2, 2022 12:33
Signed-off-by: JP Simard <jp@jpsim.com>
* origin/main:
  ci: Fix flaky coverage limit (envoyproxy#24320)
  ci: Fix change detection (part 2) (envoyproxy#24264)

Signed-off-by: JP Simard <jp@jpsim.com>
@alyssawilk alyssawilk merged commit de25488 into envoyproxy:main Dec 2, 2022
@alyssawilk alyssawilk deleted the uuid branch April 5, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants