bazel: test vendored llvm toolchain#24408
Conversation
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
keith
force-pushed
the
ks/bazel-test-vendored-llvm-toolchain
branch
from
73e9b8f to
3596686
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
Bot
added
the
stale
phlax
removed
the
stale
|
@keith i think this may still be worth investigating - im aware @lizan mentioned that it is the same statically compiled llvm bins that we currently use in the docker container - but im also wondering whether it would still save a bit of rbe/ci time as only the used bins rather than the whole suite would be getting transferred around. it also would potentially make the llvm toolchain authoritative here, which i think is also a good idea |
|
Yea I think it would have the major benefit that if folks didn't care about their compiler version there would be 0 setup. I got slightly less motivated to push it when I heard that it sounds like gcc support is required by some, so it wouldn't eliminate as much maintenance as I hoped |
keith
force-pushed
the
ks/bazel-test-vendored-llvm-toolchain
branch
from
5db5fd8 to
929cfba
Compare
I would like to hear why GCC is actually required for anyone if the entire thing could be vendored? IMO we should push this. |
|
maybe @lizan can provide more context, but it sounded like the redhat folks specifically were reliant on gcc |
keith
force-pushed
the
ks/bazel-test-vendored-llvm-toolchain
branch
from
929cfba to
48520e5
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
Bot
added
the
stale
keith
force-pushed
the
ks/bazel-test-vendored-llvm-toolchain
branch
from
48520e5 to
320968f
Compare
github-actions
Bot
removed
the
stale
|
another nail in the coffin of our current way of provisioning llvm/clang ... currently we pull the prebuilt x86_64 binaries from the llvm github project releases, but they have stopped building this from 15+ |
|
@keith is there any way we can land this for llvm and not lose gcc ? apologies if this is a naive question |
|
it's a good question, i think we could but I'm not yet sure how, i think we could probably introduce some new flag for forcing gcc and do it that way. or maybe env var. note that this toolchain also uses the llvm binary downloads so if those do go away it wouldn't work for this either. since you posted that comment some appeared to have trickled in. also I have LLVM push access so theoretically i could build and upload the ones we care about at least 😬 |
|
great - |
|
re bins - unless im misreading something - the only recent ubuntu ones are for ppcle64 |
|
yea, the other one might trickle in but who knows. there's an effort to improve this and automatically release these binaries instead of relying on various folks https://discourse.llvm.org/t/using-github-actions-for-releasing/67666 |
|
@keith im circling this again as im trying to trim down the docker build images and would like to shift clang tools into bazel im wondering if we could add this toolchain without immediately using to compile - just to use the tooling, and then hopefully switch compiler when possible |
|
see #29415 for updated PR |
3 participants
No description provided.