ads: fix MethodDescriptor resolution for ADS#2522
Closed
joeyb wants to merge 2 commits intoenvoyproxy:masterfrom
Closed
ads: fix MethodDescriptor resolution for ADS#2522joeyb wants to merge 2 commits intoenvoyproxy:masterfrom
joeyb wants to merge 2 commits intoenvoyproxy:masterfrom
Conversation
joeyb
force-pushed
the
fix-ads-descriptor
branch
2 times, most recently
from
a9652a8 to
1f6d8cc
Compare
Envoy currently segfaults if ADS is being used because resolution of the `envoy.service.discovery.v2.AggregatedDiscoveryService.StreamAggregatedResources` method fails. This fix uses the same hack as `descriptor_test.cc` to force linking so that the method is resolvable. Signed-off-by: Joey Bratton <jbratton@salesforce.com>
Signed-off-by: Joey Bratton <jbratton@salesforce.com>
joeyb
force-pushed
the
fix-ads-descriptor
branch
from
fc4e0a9 to
602de76
Compare
Contributor
|
Sorry, I hit the same issue, and have another dummy in #2495 |
Author
|
Ok, cool. I'll close this one in favor of that PR. |
Member
|
@kyessenov @htuch I'm not thrilled that there is no great way to test for this. I wonder if we should have a |
Member
|
@mattklein123 yes, we could do that, maybe just factor that code out to somewhere in |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: GitHub Action <noreply@github.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: GitHub Action <noreply@github.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy currently segfaults if ADS is being used because resolution of the
envoy.service.discovery.v2.AggregatedDiscoveryService.StreamAggregatedResourcesmethod fails. This fix uses the same hack asdescriptor_test.ccto force linking so that the method is resolvable.Risk Level: Low
Testing: Manual
Docs Changes: N/A
@kyessenov