datadog: HTTP client portion of new tracing library#25417
Merged
wbpcode merged 23 commits intoFeb 22, 2023
Merged
Conversation
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
….goffredo/dd-trace-cpp-3/9-tracer_stats' of github.com:DataDog/envoy into david.goffredo/dd-trace-cpp-7/9-agent_http_client Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Member
|
/assign |
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
wbpcode
reviewed
Feb 12, 2023
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
👍 Thanks and some minor comments are added. 😸
Contributor
Author
|
Thanks for the review. I'll commit some changes within the next couple of days. |
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Member
|
/retest |
|
Retrying Azure Pipelines: |
wbpcode
reviewed
Feb 17, 2023
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Contributor
Author
|
Ping @wbpcode |
wbpcode
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the initiative described in #23958.
This revision adds a component that will be used in the future when more of the new library is integrated into the Datadog tracing extension.
AgentHTTPClientallows the new tracing library to send spans to the Datadog Agent by making HTTP POST requests to a configured cluster.AgentHTTPClientimplements the datadog::tracing::HTTPClient interface and the Envoy::Http::AsyncClient::Callbacks interface.