http mutation filter: fix possbile illegal memory access when the req…#26112
Merged
htuch merged 3 commits intoenvoyproxy:mainfrom Mar 17, 2023
Merged
http mutation filter: fix possbile illegal memory access when the req…#26112htuch merged 3 commits intoenvoyproxy:mainfrom
htuch merged 3 commits intoenvoyproxy:mainfrom
Conversation
…uest is reset before request headers are completely received Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
Author
|
I just get some new knowledge about the filter chain from #26045. It's possible to get a nullptr request headers in the encoding phase. cc @botengyao |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…uest is reset before request headers are completely received
Commit Message: http mutation filter: fix possbile illegal memory access when the request is reset before request headers are completely received
Additional Description:
See comments in the code.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.