test: Prevent access past the end of hosts array.#2677
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Feb 27, 2018
Merged
test: Prevent access past the end of hosts array.#2677alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
Conversation
The assert test for array bounds is off by one. For a size N, hosts[N] is past the end of the array. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
ggreenway
approved these changes
Feb 26, 2018
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…ts (#2677) Instead of requiring adding the code addLogLevel() to an integration test to get finer-grained logging, now we can specify the log level on the command line via --test_arg="-l LOG_LEVEL", just like for the Envoy integration tests. For example: bazel test --test_arg="-l trace" //test/common/integration:rtds_integration_test Limitations: This flag only applies to C++ integration tests (not unit tests or other language tests). Signed-off-by: Ali Beyad <abeyad@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…ts (#2677) Instead of requiring adding the code addLogLevel() to an integration test to get finer-grained logging, now we can specify the log level on the command line via --test_arg="-l LOG_LEVEL", just like for the Envoy integration tests. For example: bazel test --test_arg="-l trace" //test/common/integration:rtds_integration_test Limitations: This flag only applies to C++ integration tests (not unit tests or other language tests). Signed-off-by: Ali Beyad <abeyad@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert test for array bounds is off by one. For a size N, hosts[N]
is past the end of the array.
Signed-off-by: Jarno Rajahalme jarno@covalent.io
Risk Level: Low