test: Only fix up IP address for socket addresses.#2678
Merged
ggreenway merged 1 commit intoenvoyproxy:masterfrom Feb 27, 2018
Merged
test: Only fix up IP address for socket addresses.#2678ggreenway merged 1 commit intoenvoyproxy:masterfrom
ggreenway merged 1 commit intoenvoyproxy:masterfrom
Conversation
If cluster's host is defined as a unix domain socket ("pipe") setting
an address changes it to a "socket_address" instead. Prevent this by
fixing addresses only if the host is already a "socket_address".
This change allows test configurations to specify clusters using unix
domain sockets. No tests do this currently, but this allows
configuration of gRPC apis (e.g., RDS) without failing on
configuration validation.
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
ggreenway
approved these changes
Feb 27, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
The initial_fetch_timeout is needed in the tests, as described in #2678 (comment). Signed-off-by: Ali Beyad <abeyad@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
The initial_fetch_timeout is needed in the tests, as described in #2678 (comment). Signed-off-by: Ali Beyad <abeyad@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If cluster's host is defined as a unix domain socket ("pipe") setting
an address changes it to a "socket_address" instead. Prevent this by
fixing addresses only if the host is already a "socket_address".
This change allows test configurations to specify clusters using unix
domain sockets. No tests do this currently, but this allows
configuration of gRPC apis (e.g., RDS) without failing on
configuration validation.
Signed-off-by: Jarno Rajahalme jarno@covalent.io
Risk Level: Low