config: Replace Utility::resourceName() with callbacks.#2684
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Mar 1, 2018
Merged
config: Replace Utility::resourceName() with callbacks.#2684htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Replace Utility::resourceName() that retrieved the name field from a set of known xDS resource types with callbacks that the subscription client for a specific resource type can provide. This change allows the gRPC subscription implemantation to be used for gRPC APIs defined by filters by not requiring a shared utility function to be updated for new resource types. Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Risk Level: Low
htuch
suggested changes
Feb 28, 2018
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks for the generalization, can you just fix typos?
|
|
||
| /** | ||
| * Obtain the "name" of a v2 API resource in a google.protobuf.Any, e.g. the route config name for | ||
| * a Routeconfiguration, based on the underlying resource type. |
|
|
||
| /** | ||
| * Obtain the "name" of a v2 API resource in a google.protobuf.Any, e.g. the route config name for | ||
| * a Routeconfiguration, based on the underlying resource type. |
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Contributor
Author
|
On Feb 28, 2018, at 2:26 PM, htuch ***@***.***> wrote:
@htuch requested changes on this pull request.
Thanks for the generalization, can you just fix typos?
Thanks for the review! Typos fixed :-)
Jarno
|
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
This gets EM to pass Envoy format checks. Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This gets EM to pass Envoy format checks. Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Utility::resourceName() that retrieved the name field from a
set of known xDS resource types with callbacks that the subscription
client for a specific resource type can provide.
This change allows the gRPC subscription implemantation to be used for
gRPC APIs defined by filters by not requiring a shared utility
function to be updated for new resource types.
Signed-off-by: Jarno Rajahalme jarno@covalent.io
Risk Level: Low