Skip to content

utility: remove absl::strings_internal::memcasecmp usage (#2700) #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 2 commits into from
Mar 5, 2018
Merged

utility: remove absl::strings_internal::memcasecmp usage (#2700) #2702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d952e6
utility: remove absl::strings_internal::memcasecmp usage (#2700)
athampy Mar 2, 2018
3d5a21f
utility: call absl::StartsWithIgnoreCase with string_view and not str…
athampy Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/common/common/utility.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "common/common/hash.h"

#include "absl/strings/ascii.h"
#include "absl/strings/internal/memutil.h"
#include "absl/strings/match.h"
#include "absl/strings/str_join.h"
#include "absl/strings/str_split.h"
#include "spdlog/spdlog.h"
Expand Down Expand Up @@ -134,7 +134,7 @@ bool StringUtil::caseCompare(absl::string_view lhs, absl::string_view rhs) {
if (rhs.size() != lhs.size()) {
return false;
}
return absl::strings_internal::memcasecmp(rhs.data(), lhs.data(), rhs.size()) == 0;
return absl::StartsWithIgnoreCase(rhs, lhs);
}

absl::string_view StringUtil::cropRight(absl::string_view source, absl::string_view delimiter) {
Expand Down