tcp filter: Allow referencing dynamic clusters in v1 config#2707
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Mar 5, 2018
Merged
tcp filter: Allow referencing dynamic clusters in v1 config#2707htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
This removes the check ensuring that the cluster referenced in the tcp filter is known. This allows users to reference a cluster that will be made available later through CDS. Signed-off-by: Snow Pettersen <snowp@squareup.com>
Member
|
@ggreenway are there any implications here that are non-obvious? @snowp I assume you really need this behavior? In general, we're pushing back on v1 enhancements but will still take them when there is a concrete need. |
ggreenway
approved these changes
Mar 5, 2018
Member
ggreenway
left a comment
There was a problem hiding this comment.
I don't think there's any hidden issues here; v2 already supports this behavior.
The only issue is if somebody is depending on this behavior for static config validation, but they'll have no path forward in v2 if they are anyways, so I think this is fine.
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* feat(edges): support configurable batch size Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * address review comments Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * address review comments Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…roxy/envoy/pull/24187/files (#2707) Fix typo in starting_envoy.rst Backport of https://github.com/envoyproxy/envoy/pull/24187/files Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…roxy/envoy/pull/24187/files (#2707) Fix typo in starting_envoy.rst Backport of https://github.com/envoyproxy/envoy/pull/24187/files Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the validation code that ensures that any cluster referenced in the tcp filter config is known when the config is applied. Removing this allows users to specify a cluster that is not known at the time but will be made available later on through CDS.
Risk Level: Low
This is already possible to do with the v2 config (as the validation was not applied in that case), so the behavior should already be battle tested. This does open up the possibility for people misconfiguring their static config (e.g. a typo when trying to reference a static cluster), although it will not break existing configs.
Testing:
None: the code path that this enables is already exercised when using the v2 config, so the existing test cases should cover this
Fixes issue #2075
cc @ggreenway