Support for gRPC accesslog unauthorized respose flag.#2756
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Mar 8, 2018
colabsaumoh:accesslog-review
Merged
Support for gRPC accesslog unauthorized respose flag.#2756htuch merged 1 commit intoenvoyproxy:masterfrom colabsaumoh:accesslog-review
htuch merged 1 commit intoenvoyproxy:masterfrom
colabsaumoh:accesslog-review
Conversation
Signed-off-by: Saurabh Mohan <saurabh+github@tigera.io>
htuch
reviewed
Mar 8, 2018
| } | ||
|
|
||
| if (request_info.getResponseFlag(RequestInfo::ResponseFlag::UnauthorizedExternalService)) { | ||
| common_access_log.mutable_response_flags()->mutable_unauthorized_details()->set_reason( |
Member
There was a problem hiding this comment.
It's a bit weird that we have "details" in a "response_flags" message, but that's an API level concern. I wonder if we should rename that before moving it out of "not implemented" status. Thoughts?
Contributor
Author
There was a problem hiding this comment.
may be rename "_details" to "_reasons". That way we can set multiple reasons under it?
Member
There was a problem hiding this comment.
I'm thinking rename response_flags to response_details or response_info, i.e. it's no longer just flags. I'll merge this, but just putting this out there for future followup. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: Add support for response flag unauthorized (by external service) in gRPC access log.
Adding support for gRPC access log support for response flag Unauthorized.
Here we are adding support for envoyproxy/data-plane-api#505
Risk Level: Low
Small optional feature.
Testing:
Added UT's.
Docs Changes: N/A
Signed-off-by: Saurabh Mohan saurabh+github@tigera.io