tooling: include protoc-gen-jsonschema repository#27661
Merged
Conversation
Signed-off-by: norbjd <norbjd@users.noreply.github.com>
phlax
reviewed
May 27, 2023
phlax
reviewed
May 27, 2023
Signed-off-by: norbjd <norbjd@users.noreply.github.com>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
reviewed
May 29, 2023
Signed-off-by: norbjd <norbjd@users.noreply.github.com>
Signed-off-by: norbjd <norbjd@users.noreply.github.com>
phlax
reviewed
May 30, 2023
…d of manually copying it Signed-off-by: norbjd <norbjd@users.noreply.github.com>
phlax
reviewed
May 30, 2023
Member
phlax
left a comment
There was a problem hiding this comment.
if you remove the added BUILD file ci should pass now i think
Signed-off-by: norbjd <norbjd@users.noreply.github.com>
Contributor
Author
|
Should be good now, everything unnecessary has been removed 🧹 |
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Signed-off-by: norbjd <norbjd@users.noreply.github.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Include protoc-gen-jsonschema repository that will be used to generate JSON schemas from protobuf files.
Additional Description
Split from #27640 following @phlax demand.
This PR is a prerequisite to generate JSON schemas from protobuf files. First, we want to make sure everything's working after including that repository.
The
protoc-gen-jsonschemarepository used is still a fork I've made to bazelify the repo before including it here (chrusty/protoc-gen-jsonschema@master...norbjd:protoc-gen-jsonschema:add-bazel); if everything's good I plan to contribute to chrusty's upstream repository.Risk Level
Low
Testing
I have added a dummy rule to confirm the setup works.
$ bazel build //tools/protojsonschema:envoy_annotations_jsonschema $ cat bazel-bin/tools/protojsonschema/envoy_annotations_jsonschema { "$schema": "http://json-schema.org/draft-04/schema#", "$ref": "#/definitions/ResourceAnnotation", "definitions": { "ResourceAnnotation": { "properties": { "type": { "type": "string" } }, "additionalProperties": true, "type": "object" } } }Docs Changes
/
Release Notes
Include protoc-gen-jsonschema repository
Platform Specific Features
/