Skip to content

tls:remove unimplemented options from one of description#27786

Closed
ramaraochavali wants to merge 1 commit intoenvoyproxy:mainfrom
ramaraochavali:fix/tls_comments
Closed

tls:remove unimplemented options from one of description#27786
ramaraochavali wants to merge 1 commit intoenvoyproxy:mainfrom
ramaraochavali:fix/tls_comments

Conversation

@ramaraochavali
Copy link
Copy Markdown
Contributor

Commit Message: remove unimplemented options from one of description
Additional Description:
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #27786 was opened by ramaraochavali.

see: more, trace.

@ravenblackx
Copy link
Copy Markdown
Contributor

Review SLA ping @lizan

Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added in #17201, and these options may be in-use by gRPC.
If so, a note can be added describing which fields are relevant for Envoy.

@markdroth can you PTAL?

@KBaichoo KBaichoo assigned markdroth and unassigned lizan Jun 12, 2023
@KBaichoo
Copy link
Copy Markdown
Contributor

Can you chime in @markdroth ? Thanks

@markdroth
Copy link
Copy Markdown
Contributor

That's correct, gRPC does implement the tls_certificate_provider_instance field, and it is mutually exclusive with the other two, so the comment is correct as-is. If you want to add a note that Envoy does not yet support that field, that's fine.

@ramaraochavali
Copy link
Copy Markdown
Contributor Author

If there is a plan for Envoy to support that in future, I think we can close this.

@ramaraochavali ramaraochavali deleted the fix/tls_comments branch June 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants