Skip to content

[Ext_proc]: only allow clear_route_cache on the INBOUND responses.#27828

Closed
stevenzzzz wants to merge 3 commits intoenvoyproxy:mainfrom
stevenzzzz:ext_proc
Closed

[Ext_proc]: only allow clear_route_cache on the INBOUND responses.#27828
stevenzzzz wants to merge 3 commits intoenvoyproxy:mainfrom
stevenzzzz:ext_proc

Conversation

@stevenzzzz
Copy link
Copy Markdown
Contributor

Commit Message: Only allow clear_route_cache be performed on the request path, make it an NO-OP on the response path.
Additional Description:
Risk Level: LOW, filter in alpha
Testing: unit test
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
@stevenzzzz stevenzzzz requested a review from snowp as a code owner June 6, 2023 20:30
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #27828 was opened by stevenzzzz.

see: more, trace.

@stevenzzzz
Copy link
Copy Markdown
Contributor Author

/assign @yanavlasov

@stevenzzzz
Copy link
Copy Markdown
Contributor Author

/assign @yanjunxiang-google

Signed-off-by: Xin Zhuang <stevenzzz@google.com>
@stevenzzzz
Copy link
Copy Markdown
Contributor Author

hmm, #27657 is taking care of this in a different approach.
revert this PR now.

@stevenzzzz stevenzzzz closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants