Skip to content

Credentials Injector http filter extension implementation#28027

Closed
vikaschoudhary16 wants to merge 6 commits intoenvoyproxy:mainfrom
vikaschoudhary16:feature/credentials-filter
Closed

Credentials Injector http filter extension implementation#28027
vikaschoudhary16 wants to merge 6 commits intoenvoyproxy:mainfrom
vikaschoudhary16:feature/credentials-filter

Conversation

@vikaschoudhary16
Copy link
Copy Markdown
Contributor

Commit Message: This is a draft PR for the implementation of api proposed in #27769 to help api review.

@yskopets is the original author of changes in this PR.

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>
Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>
@vikaschoudhary16 vikaschoudhary16 marked this pull request as draft June 19, 2023 06:27
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #28027 was opened by vikaschoudhary16.

see: more, trace.

@vikaschoudhary16 vikaschoudhary16 changed the title Credentials Filter extension implementation Credentials Injector http filter extension implementation Jun 19, 2023
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title underlines in rst need to be at least as long as the text (preferably same length)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links should be rst links

Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
This reverts commit 41dd338.

Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
@vikaschoudhary16 vikaschoudhary16 force-pushed the feature/credentials-filter branch from 9358b8c to bdfbb77 Compare June 19, 2023 08:28
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 19, 2023
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Jul 26, 2023
@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

this is not stale. Just waiting for the linked api PR to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants