upstream subset lb: add redundant keys support#28874
upstream subset lb: add redundant keys support#28874wbpcode merged 26 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for working on this.
Left a high-level comment about this new feature.
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/28874/docs/index.html The docs are (re-)rendered each time the CI |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
friendly ping @adisuissa |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/28874/docs/index.html The docs are (re-)rendered each time the CI |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
cc @zuercher test was updated. 😸 |
|
cc @adisuissa any other concern to the API? 🤔 |
adisuissa
left a comment
There was a problem hiding this comment.
Left a few nits, but otherwise api lgtm.
Consider emphasizing that this is a 2step algorithm, choosing the keys subset first, and only then matching their values (so it won’t be mistaken with choosing the subset of keys+values that match w/o the redundant keys)
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
…proto Co-authored-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: code <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
cc @adisuissa Thanks for your detailed review. Related comments are addressed and comment of API is updated. |
|
Hi, @zuercher, could you give another LGTM. We updated API's comment after your code review. Thanks. |
Signed-off-by: code <wangbaiping@corp.netease.com>
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @zuercher |
|
cc @RyanTheOptimist (on-call maintainer) Hi, could you give this PR another LGTM? @zuercher has approved this PR before. And after his approve, we just update the API's comments. But seems @zuercher is busy recently and has no github activities. |
|
ho, @zuercher thanks 🙏 |

Commit Message: upstream subset lb: add redundant keys support
Additional Description:
Description is same with the comment:
Risk Level: low. minor change.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.