clang/tools: Use python distributed versions#29455
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Sep 11, 2023
Merged
Conversation
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
b968346 to
b2b24c1
Compare
4465523 to
5a2a6da
Compare
phlax
commented
Sep 7, 2023
phlax
commented
Sep 7, 2023
391e288 to
7a4030c
Compare
Member
Author
|
not sure why but this has terrible performance - possibly using the entry_point - ill debug further |
Member
Author
|
hmm - yep the python wrapper seems to add 200ms per call and theres a lot of calls $ time bazel run //tools/code_format:py-clang-format "${PWD}/source/extensions/http/cache/simple_http_cache/simple_http_cache.cc"
real 0m0.360s
user 0m0.239s
sys 0m0.035s$ time bazel run //tools/code_format:clang-format "${PWD}/source/extensions/http/cache/simple_http_cache/simple_http_cache.cc"
real 0m0.091s
user 0m0.006s
sys 0m0.018s |
Member
Author
|
committing the binary from the python package directly to the repo and using that and ci runs at usual speed |
Member
Author
|
... as does adding a bazel rule to fish the binary out of the python package |
eb13fc4 to
c3d54c2
Compare
21a0d83 to
a4ea72f
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
a4ea72f to
af84a17
Compare
keith
approved these changes
Sep 11, 2023
keith
approved these changes
Sep 11, 2023
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax
added a commit
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Sep 21, 2023
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This massively reduces the overhead for running the clang tooling
In this PR only clang-format is hooked up to the format precheck, but we can use the clang-tidy install when bringing it back
Ideally we would be able to do the same with lcov and friends which would reduce the cost of running coverage, but i dont see a package for them
We may decide in the future to fetch these tools from a different channel - the one in this PR is not ideal although it meets our current needs
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]