Skip to content

remove expired runtime flag: envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent#30444

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
wbpcode:dev-remove-runtime-route
Oct 24, 2023
Merged

remove expired runtime flag: envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent#30444
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
wbpcode:dev-remove-runtime-route

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented Oct 24, 2023

Commit Message: remove expired runtime flag: envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent
Additional Description:

To close #30423.

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…_refresh_after_response_headers_sent

Signed-off-by: wbpcode <wbphub@live.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #30444 was opened by wbpcode.

see: more, trace.

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha boo, you won the merge race

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_prohibit_route_refresh_after_response_headers_sent deprecation

2 participants