[bp/1.28] Datadog: restore "resource.name" tag (#30503)#30893
Merged
htuch merged 2 commits intoNov 16, 2023
Conversation
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
|
Hi @Smeb, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Smeb
changed the title
Author
|
👀 Looking into presubmit issue -> examples issue looks accurate. Will investigate further tomorrow. |
Author
|
/retest |
htuch
approved these changes
Nov 16, 2023
SeanKilleen
pushed a commit
to SeanKilleen/envoy
that referenced
this pull request
Apr 3, 2024
…voyproxy#30893) This is the backport of envoyproxy#30503 Risk Level: low Testing: local unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Fixes: envoyproxy#30235 Signed-off-by: David Goffredo <david.goffredo@datadoghq.com> Signed-off-by: Ben Ryves <smeb@gmail.com> Co-authored-by: David Goffredo <david.goffredo@datadoghq.com> Co-authored-by: Ben Ryves <smeb@gmail.com> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋 - I hope opening a backport like this is the right approach. We would like to have this fix so that we can upgrade to 1.27/1.28 in our cluster - without it our trace spans have incorrect names.
I ran the tests locally as follows
bazel test --config=libc++ //test. I used libc because my development environment had an unrelated issue with using the stdlib, which I believe is related to #30837.Commit Message: [bp/1.28] Datadog: restore "resource.name" tag (#30503)
Additional Description:
This is the backport of #30503
Risk Level: low
Testing: local unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes: #30235