mobile: removing guarddog and watchdog#30896
Merged
Merged
Conversation
alyssawilk
force-pushed
the
strip_guarddog
branch
4 times, most recently
from
719955d to
3ea00c5
Compare
Contributor
Author
|
/retest |
alyssawilk
force-pushed
the
strip_guarddog
branch
2 times, most recently
from
6070d23 to
71e619a
Compare
alyssawilk
force-pushed
the
strip_guarddog
branch
from
71e619a to
209ea6e
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
strip_guarddog
branch
from
209ea6e to
0ba6509
Compare
abeyad
approved these changes
Nov 27, 2023
| "main_thread", *dispatcher_); | ||
| WatchDogSharedPtr watchdog; | ||
| if (main_thread_guard_dog_) { | ||
| watchdog = main_thread_guard_dog_->createWatchDog(api_->threadFactory().currentThreadId(), |
Contributor
There was a problem hiding this comment.
Just for my own understanding, I get why on L823, the watch dog is optional on the listener since EM doesn't use traditional listeners. But I'm not clear on why we want to make the watch dog optional for the main thread?
Contributor
Author
There was a problem hiding this comment.
android already kills stuck apps - I don't think we need envoy internal handling for this
zuercher
approved these changes
Nov 28, 2023
RyanTheOptimist
pushed a commit
that referenced
this pull request
Feb 27, 2026
…ig (#43522) Commit Message: watch-dog: fix worker-thread watch-dog threads using main-thread config Additional Description: In PR #30896 the watchdog instantiation was refactored, and a bug was introduced where both the main thread's and the worker threads' watch-dogs are configured [using the main-thread's config](https://github.com/envoyproxy/envoy/pull/30896/changes#diff-a39ff317d26d008f20bca53f5e3f4e171d169a5702f82409ca941bddaac46064L781-L784). This PR fixes the issue by passing the correct configuration. Risk Level: Medium - may change the behavior of systems where worker-threads' watch-dogs will trigger. Testing: Added unit and integration tests. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Runtime guard: Added `envoy.restart_features.worker_threads_watchdog_fix` that can temporarily disable the fix. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com>
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…ig (envoyproxy#43522) Commit Message: watch-dog: fix worker-thread watch-dog threads using main-thread config Additional Description: In PR envoyproxy#30896 the watchdog instantiation was refactored, and a bug was introduced where both the main thread's and the worker threads' watch-dogs are configured [using the main-thread's config](https://github.com/envoyproxy/envoy/pull/30896/changes#diff-a39ff317d26d008f20bca53f5e3f4e171d169a5702f82409ca941bddaac46064L781-L784). This PR fixes the issue by passing the correct configuration. Risk Level: Medium - may change the behavior of systems where worker-threads' watch-dogs will trigger. Testing: Added unit and integration tests. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Runtime guard: Added `envoy.restart_features.worker_threads_watchdog_fix` that can temporarily disable the fix. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…ig (envoyproxy#43522) Commit Message: watch-dog: fix worker-thread watch-dog threads using main-thread config Additional Description: In PR envoyproxy#30896 the watchdog instantiation was refactored, and a bug was introduced where both the main thread's and the worker threads' watch-dogs are configured [using the main-thread's config](https://github.com/envoyproxy/envoy/pull/30896/changes#diff-a39ff317d26d008f20bca53f5e3f4e171d169a5702f82409ca941bddaac46064L781-L784). This PR fixes the issue by passing the correct configuration. Risk Level: Medium - may change the behavior of systems where worker-threads' watch-dogs will trigger. Testing: Added unit and integration tests. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Runtime guard: Added `envoy.restart_features.worker_threads_watchdog_fix` that can temporarily disable the fix. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…ig (envoyproxy#43522) Commit Message: watch-dog: fix worker-thread watch-dog threads using main-thread config Additional Description: In PR envoyproxy#30896 the watchdog instantiation was refactored, and a bug was introduced where both the main thread's and the worker threads' watch-dogs are configured [using the main-thread's config](https://github.com/envoyproxy/envoy/pull/30896/changes#diff-a39ff317d26d008f20bca53f5e3f4e171d169a5702f82409ca941bddaac46064L781-L784). This PR fixes the issue by passing the correct configuration. Risk Level: Medium - may change the behavior of systems where worker-threads' watch-dogs will trigger. Testing: Added unit and integration tests. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Runtime guard: Added `envoy.restart_features.worker_threads_watchdog_fix` that can temporarily disable the fix. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…ig (envoyproxy#43522) Commit Message: watch-dog: fix worker-thread watch-dog threads using main-thread config Additional Description: In PR envoyproxy#30896 the watchdog instantiation was refactored, and a bug was introduced where both the main thread's and the worker threads' watch-dogs are configured [using the main-thread's config](https://github.com/envoyproxy/envoy/pull/30896/changes#diff-a39ff317d26d008f20bca53f5e3f4e171d169a5702f82409ca941bddaac46064L781-L784). This PR fixes the issue by passing the correct configuration. Risk Level: Medium - may change the behavior of systems where worker-threads' watch-dogs will trigger. Testing: Added unit and integration tests. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Runtime guard: Added `envoy.restart_features.worker_threads_watchdog_fix` that can temporarily disable the fix. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: low (refactor for Envoy)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a