update all getServerFactoryContext to serverFactoryContext#31150
Merged
wbpcode merged 36 commits intoenvoyproxy:mainfrom Dec 5, 2023
Merged
update all getServerFactoryContext to serverFactoryContext#31150wbpcode merged 36 commits intoenvoyproxy:mainfrom
wbpcode merged 36 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
…lean-common-factory-context
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
wbpcode
requested review from
KBaichoo,
RyanTheOptimist,
abeyad,
adisuissa,
alyssawilk,
ggreenway,
htuch,
jmarantz,
kyessenov,
lizan,
mattklein123,
nezdolik,
ravenblackx,
yanavlasov and
zuercher
as code owners
Member
Author
|
Waiting for #31072 to be merged first. |
Signed-off-by: wbpcode <wbphub@live.com>
wbpcode
force-pushed
the
dev-clean-up-factory-name
branch
from
3140389 to
b584cae
Compare
…lean-up-factory-name
Member
Author
|
Merged main and resolve conflicts. cc Hi, @alyssawilk, could you give a new stamp? |
alyssawilk
approved these changes
Dec 5, 2023
delphisfang
pushed a commit
to delphisfang/envoy
that referenced
this pull request
Dec 10, 2023
…y#31150) * cleanup all common factory context Signed-off-by: wbpcode <wbphub@live.com> * fix visitor Signed-off-by: wbpcode <wbphub@live.com> * minor update Signed-off-by: wbpcode <wbphub@live.com> * fix building Signed-off-by: wbpcode <wbphub@live.com> * fix format Signed-off-by: wbpcode <wbphub@live.com> * fix test Signed-off-by: wbpcode <wbphub@live.com> * fix building again Signed-off-by: wbpcode <wbphub@live.com> * fix test Signed-off-by: wbpcode <wbphub@live.com> * add more cost Signed-off-by: wbpcode <wbphub@live.com> * hate keyboard of mac Signed-off-by: wbpcode <wbphub@live.com> * new generic factory context Signed-off-by: wbpcode <wbphub@live.com> * minor fix Signed-off-by: wbpcode <wbphub@live.com> * fix build Signed-off-by: wbpcode <wbphub@live.com> * fix fix fix Signed-off-by: wbpcode <wbphub@live.com> * fix building Signed-off-by: wbpcode <wbphub@live.com> * workaround Signed-off-by: wbpcode <wbphub@live.com> * again fix building Signed-off-by: wbpcode <wbphub@live.com> * fix spelling Signed-off-by: wbpcode <wbphub@live.com> * fix test Signed-off-by: wbpcode <wbphub@live.com> * fix test one by one Signed-off-by: wbpcode <wbphub@live.com> * fix test Signed-off-by: wbpcode <wbphub@live.com> * should be final commit Signed-off-by: wbpcode <wbphub@live.com> * fix... Signed-off-by: wbpcode <wbphub@live.com> * address comments Signed-off-by: wbpcode <wbphub@live.com> * resolve coverage problem Signed-off-by: wbpcode <wbphub@live.com> * fix test Signed-off-by: wbpcode <wbphub@live.com> * try to improve coverage Signed-off-by: wbpcode <wbphub@live.com> * minor update Signed-off-by: wbpcode <wbphub@live.com> * save file Signed-off-by: wbpcode <wbphub@live.com> * remove unexpected updates Signed-off-by: wbpcode <wbphub@live.com> * fix building Signed-off-by: wbpcode <wbphub@live.com> * coverage Signed-off-by: wbpcode <wbphub@live.com> * update all getServerFactoryContext to serverFactoryContext Signed-off-by: wbpcode <wbphub@live.com> --------- Signed-off-by: wbpcode <wbphub@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: update all getServerFactoryContext to serverFactoryContext
Additional Description:
Because of the historical reason, there are two different method to get server factory context reference,
getServerFactoryContextandserverFactoryContext.This patch do a simple global replacement to update all
getServerFactoryContexttoserverFactoryContext.Risk Level: low, only a simple global name replacement.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.