server: mutex-protect the drain timeout, and attempt to repro a race.#31432
Closed
jmarantz wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
server: mutex-protect the drain timeout, and attempt to repro a race.#31432jmarantz wants to merge 1 commit intoenvoyproxy:mainfrom
jmarantz wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
A better approach might be to have the drain-timeout be thread-local and post an update to that in all worker threads. @mattklein123 WDYT? |
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I don't think access of this is perf critical so seems fine to me? I'm sure it's not standard compliant, but I would imagine sizeof(MonotonicTime) is 8 on the platforms we care about and you could probably jam it in an atomic and cast it back and forth if you really cared to?
Contributor
Author
|
wound up starting again with #31452 and will close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]