oauth2: Add default expiry for RFC compliance#31499
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/31499/docs/index.html The docs are (re-)rendered each time the CI |
|
/retest |
|
this appears to work as expected in local testing |
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Left a small API comment.
cc @derekargueta @mattklein123 oauth2 code-owners.
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
/lgtm api
Assigning Matt as codeowner.
/assign @mattklein123
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Oh, I think it needs a release note as well.
|
apologies for fp - im rebasing on this pr so it was to avoid the merge commit, pr commits were not changed |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
3 participants
Currently this filter does not work with Github - which would seem like one of the most likely use cases
This is a revival of #14625
Should fix #14542
Unblocks #31534
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]