[bp/1.28] datadog: fix names in Span::spawnChild#31595
Merged
phlax merged 2 commits intoJan 4, 2024
Merged
Conversation
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
phlax
reviewed
Jan 3, 2024
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
same for this one - can we add the changelog please
Member
|
@dgoffredo im wondering if 1.26 also requires the fix (1.25 is going EOL shortly so possibly wont get another release) |
Contributor
Author
v1.26 does not contain the rewrite that introduced this bug. Previously, I mistakenly said that v1.26 includes the rewrite, but it does not. The rewrite added code file-by-file to the source tree, but the switch to the new implementation did not happen until after v1.26 was cut. |
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Member
|
verify fail is unrelated to this pr - the branch requires a backport - ill resolve shortly |
SeanKilleen
pushed a commit
to SeanKilleen/envoy
that referenced
this pull request
Apr 3, 2024
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #31366 onto the v1.28 release branch.
These changes fix a bug in the Datadog tracing extension. Previously,
Span::spawnChildwould produce spans whose "operation name" had the value of what should instead be the "resource name." With these changes, setting the "operation name" sets the "resource name" instead, and the "operation name" is always the hard-coded value "envoy.proxy".