Skip to content

update changelog for #31669#31698

Merged
phlax merged 1 commit into
envoyproxy:mainfrom
DataDog:david.goffredo/changelog-for-datadog-fix-span-error-property
Jan 8, 2024
Merged

update changelog for #31669#31698
phlax merged 1 commit into
envoyproxy:mainfrom
DataDog:david.goffredo/changelog-for-datadog-fix-span-error-property

Conversation

@dgoffredo
Copy link
Copy Markdown
Contributor

I forgot to update changelogs/current.yaml in #31669.

This pull request has the appropriate bug_fixes entry.

@dgoffredo
Copy link
Copy Markdown
Contributor Author

When will I learn to --signoff? Maybe I can add a git hook...

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @dgoffredo

Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Jan 8, 2024

could you fix DCO please @dgoffredo

@dgoffredo dgoffredo force-pushed the david.goffredo/changelog-for-datadog-fix-span-error-property branch from a8453c0 to 1702b76 Compare January 8, 2024 16:31
@phlax phlax merged commit d0722b0 into envoyproxy:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants