[bp/1.27] datadog: fix span error property#31703
Merged
phlax merged 1 commit intoJan 9, 2024
Merged
Conversation
Member
|
failures are unrelated flakey upstream - there is a pr to fix this somewhere - i think it got closed as unneeded - ill check now ... |
Member
|
@dgoffredo should be fixed - could you rebase these 2 prs please, and ill land |
dgoffredo
force-pushed
the
david.goffredo/backport-v1.27-datadog-fix-span-error-property
branch
from
cffe7eb to
bd33c86
Compare
Contributor
Author
|
GitHub is not having a nice time. |
Member
|
yeah - its a known/acknowledged problem - https://www.githubstatus.com/ |
Member
|
/retest |
Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
auto-merge was automatically disabled
January 9, 2024 14:10
Head branch was pushed to by a user without write access
dgoffredo
force-pushed
the
david.goffredo/backport-v1.27-datadog-fix-span-error-property
branch
from
bd33c86 to
4249562
Compare
phlax
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #31669 onto the v1.27 release branch.
These changes fix a bug in the Datadog tracing extension. In releases before v1.27, when the "error" tag was set on a Datadog span, a corresponding private property on the span would also be set to indicate the presence of an error. Release v1.27 included a rewrite of the Datadog tracing extension that removed this behavior, and the removal is a bug. These changes restore the old behavior.