ci/codeql: Fix build target acquisition#31722
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Jan 9, 2024
Merged
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
cc @mmorel-35 |
ravenblackx
previously approved these changes
Jan 9, 2024
| paths: | ||
| - 'source/common/**' | ||
| - include/** | ||
| - source/common/** |
Contributor
There was a problem hiding this comment.
Could you either include the ' delimiters like it used to, or also remove them from branches-ignore below, for consistency.
Member
Author
There was a problem hiding this comment.
ill remove them from below - that is more consistent with the rest of the code base
ravenblackx
previously approved these changes
Jan 9, 2024
Signed-off-by: Ryan Northey <ryan@synca.io>
ravenblackx
approved these changes
Jan 9, 2024
jbohanon
reviewed
Jan 15, 2024
| # TODO(phlax): Shift this to an action | ||
| compare_head () { | ||
| while IFS= read -r line; do | ||
| echo "CHECK: ${line}" |
Contributor
Member
Author
There was a problem hiding this comment.
it certainly should (EDIT: should not) be here - altho im a bit confused as it does appear to be working elsewhere - so im thinking its not the cause of your problem - which afaict is more to do with an empty line being returned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]