http: add downstream remote reset response flag#32623
Merged
wbpcode merged 10 commits intoenvoyproxy:mainfrom Mar 8, 2024
Merged
http: add downstream remote reset response flag#32623wbpcode merged 10 commits intoenvoyproxy:mainfrom
wbpcode merged 10 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Boteng Yao <boteng@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Contributor
|
PTAL @wbpcode |
adisuissa
reviewed
Mar 5, 2024
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Left a minor comment.
Please add a release note.
| response_encoder_.stream_.resetStream(StreamResetReason::ConnectError); | ||
| } | ||
|
|
||
| TEST_F(HttpConnectionManagerImplTest, DownstreamRemoteResetRemoteReset) { |
Contributor
There was a problem hiding this comment.
nit: modify test-name (double RemoteReset) and add a one-line comment for each test
| response_encoder_.stream_.resetStream(StreamResetReason::RemoteReset); | ||
| } | ||
|
|
||
| TEST_F(HttpConnectionManagerImplTest, DownstreamRemoteResetRemoteRefusedStreamReset) { |
wbpcode
reviewed
Mar 6, 2024
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM except the comment from @adisuissa
Member
|
Could you also check the CI failure? |
Member
|
/wait |
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Member
Author
|
/retest |
Member
|
/lgtm api |
Member
|
/wait ci and merge main |
Member
Author
|
/retest |
Signed-off-by: Boteng Yao <boteng@google.com>
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add response flag DownstreamRemoteReset when the http2 details are
http2.remote_resetorhttp2.remote_refusehereThis is similar as what router does for upstream
envoy/source/common/router/router.cc
Lines 1437 to 1440 in 8e93d16
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]