qatzstd: remove useless build parameters#33143
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Mar 27, 2024
Merged
Conversation
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
|
cc @wbpcode would you help me to take a look at this? thanks! |
Member
Author
|
also cc @zhxie |
zhxie
approved these changes
Mar 27, 2024
Contributor
zhxie
left a comment
zhxie
left a comment
There was a problem hiding this comment.
LGTM. Configure options better to be ordered alphabetically.
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: qatzstd: remove useless build parameters
Additional Description:
Those useless building parameters break the CI of istio proxy istio/proxy#5411 (comment)
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a