mobile: Allow the Kotlin XdsTest to accept untrusted certs#33381
Closed
abeyad wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
mobile: Allow the Kotlin XdsTest to accept untrusted certs#33381abeyad wants to merge 2 commits intoenvoyproxy:mainfrom
abeyad wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
The test only sends requests to a local server. Unfortunately, upstreamcacert.pem has expired as of Apr 6, 2024. While we work out generating a new cert, this solves a current permafail in the XdsTest, and ACCEPT_UNTRUSTED is used in other mobile integration tests. Signed-off-by: Ali Beyad <abeyad@google.com>
abeyad
requested review from
RyanTheOptimist,
alyssawilk and
fredyw
as code owners
Contributor
Author
|
/assign @alyssawilk |
Member
|
hopefully this should not be required - i have rebuilt the certs in #33389 |
alyssawilk
approved these changes
Apr 8, 2024
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM but disabling automerge as I think we can revert
Contributor
|
/wait to keep it out of my dashboard =P |
Member
|
i think this issue was fixed - shall we close this @abeyad ? |
Contributor
Author
|
Yup, closed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test only sends requests to a local server. Unfortunately,
upstreamcacert.pemhas expired as of Apr 6, 2024[1]. While we work out generating a new cert, this solves a current permafail in the XdsTest, andACCEPT_UNTRUSTEDis used in other mobile integration tests (e.g.envoy/mobile/test/kotlin/integration/ReceiveTrailersTest.kt
Line 55 in f580ed0
[1] Determined by running
openssl x509 -in test/config/integration/certs/upstreamcacert.pem -text -noout