Adding integration test for match_delegate + composite + callout_filter in both downstrean and upstream#33579
Merged
yanavlasov merged 3 commits intoenvoyproxy:mainfrom Apr 22, 2024
Conversation
…ter configured in either downstream or upstream Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
requested review from
htuch,
mattklein123 and
yanavlasov
as code owners
Contributor
Author
|
/assign @htuch @tyxia @yanavlasov |
Contributor
Author
|
/retest |
yanavlasov
previously approved these changes
Apr 17, 2024
Contributor
Contributor
Author
The CI issue should be resolved now. |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
tyxia
reviewed
Apr 18, 2024
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM modulo one question in test.
Thanks!
yanjunxiang-google
changed the title
Contributor
Author
|
Kind ping! |
yanavlasov
approved these changes
Apr 22, 2024
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Apr 25, 2024
…er in both downstrean and upstream (envoyproxy#33579) --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…er in both downstrean and upstream (envoyproxy#33579) --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adding integration test to verify match_delegate + composite + callout_filter works in both downstream and upstream.
It addresses this comments: #33273 (review)
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]