Skip to content

docs: remove not-implemented-hide for statsd sink prefix#3358

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
snowp:implemented
May 11, 2018
Merged

docs: remove not-implemented-hide for statsd sink prefix#3358
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
snowp:implemented

Conversation

@snowp
Copy link
Copy Markdown
Contributor

@snowp snowp commented May 11, 2018

title: docs: remove not-implemented-hide for statsd sink prefix

Description:
This seems to have been implemented in
#3029.

Risk Level:
Low: Docs change

Testing:
N/A

Docs Changes:
Unhides the statsd prefix option

Release Notes:
N/A

This seems to have been implemented in
envoyproxy#3029.

Signed-off-by: Snow Pettersen <snowp@squareup.com>
@snowp
Copy link
Copy Markdown
Contributor Author

snowp commented May 11, 2018

Looks like there's no release note for this either as far as I can tell, I can add that too if that's desirable

@mattklein123
Copy link
Copy Markdown
Member

@snowp yes please add a release note if you don't mind!

Signed-off-by: Snow Pettersen <snowp@squareup.com>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 45d3e3f into envoyproxy:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants